Date: Thu, 30 Jul 2009 15:31:58 +0200 From: Thomas Backman <serenity@exscape.org> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-fs@freebsd.org, FreeBSD current <freebsd-current@freebsd.org>, Pawel Jakub Dawidek <pjd@freebsd.org> Subject: Re: zfs: Fatal trap 12: page fault while in kernel mode Message-ID: <19347561-3CE6-40B3-930A-EB9925D3AFD1@exscape.org> In-Reply-To: <4A719CA4.4060400@freebsd.org> References: <20090727072503.GA52309@jpru.ffm.jpru.de> <4A6E06E6.9030300@mail.zedat.fu-berlin.de> <4A6EC9E2.5070200@icyb.net.ua> <20090729084723.GD1586@garage.freebsd.pl> <F4F82B3E-C119-40EF-9AA4-937052876D1E@exscape.org> <4A7030B6.8010205@icyb.net.ua> <97D5950F-4E4D-4446-AC22-92679135868D@exscape.org> <4A7048A9.4020507@icyb.net.ua> <52AA86CB-6C06-4370-BA73-CE19175467D0@exscape.org> <4A705299.8060504@icyb.net.ua> <D3491B77-DA5C-4E10-BE1D-D6EF8CFB112E@exscape.org> <4A7054E1.5060402@icyb.net.ua> <5918824D-A67C-43E6-8685-7B72A52B9CAE@exscape.org> <4A705E50.8070307@icyb.net.ua> <4A70728C.7020004@freebsd.org> <6D47A34B-0753-4CED-BF3D-C505B37748FC@exscape.org> <4A708455.5070304@freebsd.org> <86983A55-E5C4-4C04-A4C7-0AE9A9EE37A3@exscape.org> <4A718E03.6030909@freebsd.org> <71A038EC-02B1-4606-96C2-5E84BE80F005@exscape.org> <4A719CA4.4060400@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Jul 30, 2009, at 15:14, Andriy Gapon wrote:
> Thomas,
>
> I wasn't clear - please make sure that you have original
> zfs_inactive (without the
> changes that Pawel proposed) with the only change zfs_znode_free ->
> vrecycle.
> I.e.:
> if (zp->z_dbuf == NULL) {
> /*
> * The fs has been unmounted, or we did a
> * suspend/resume and this file no longer exists.
> */
> mutex_enter(&zp->z_lock);
> VI_LOCK(vp);
> vp->v_count = 0; /* count arrives as 1 */
> mutex_exit(&zp->z_lock);
> rw_exit(&zfsvfs->z_teardown_inactive_lock);
> vrecycle(vp, curthread);
> return;
> }
>
> I believe that the latest panic is a direct result of ZTOV(zp) =
> NULL line
> introduced in zfs_vnops.c.2.patch.
>
> reclaim function should stay patched with Pawel's patch.
Hey, it works!!! :)
For the first time ever, my now mislabeled "clone_crash.sh" doesn't
panic! A quick test of my ordinary, actually-used backup script also
worked fine!
For the record, here's the diff I got: http://exscape.org/temp/zfs_vnops.c.patch
Thanks a lot! Hope to see this tested further (I'll do some more
testing for sure) so that we can consider it a stable change.
Regards,
Thomas
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19347561-3CE6-40B3-930A-EB9925D3AFD1>