Date: Tue, 31 Jan 2006 17:36:48 +0300 From: Yar Tikhiy <yar@comp.chem.msu.su> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: alc@FreeBSD.org, freebsd-bugs@FreeBSD.org Subject: Re: kern/92243: sendfile(2) returns early on files > 4GB Message-ID: <20060131143648.GA34373@comp.chem.msu.su> In-Reply-To: <1198.1138716960@critter.freebsd.dk> References: <200601311410.k0VEAASn057130@freefall.freebsd.org> <1198.1138716960@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 31, 2006 at 02:16:00PM +0000, Poul-Henning Kamp wrote: > In message <200601311410.k0VEAASn057130@freefall.freebsd.org>, Yar Tikhiy write > s: > > > Quite curiously, changing the type of the size argument to > > vnode_create_vobject() from size_t to off_t seems to remedy the > > problem in my case. Let's ask Poul-Henning, who introduced the > > kernel function a year ago, what he thinks about this -- adding him > > to CC. > > Oversight on my part. My last concern is whether off_t is correct there, or it should be vm_ooffset_t. I.e., should the size argument represent a file size or VM object size? As a matter of fact, the size argument is transformed into vm_ooffset_t inside vnode_create_vobject(), so we can safely decide that vnode_create_vobject() is on the vnode side of the vnode-VM interface. Thanks! -- Yar
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060131143648.GA34373>