Date: Wed, 1 Feb 2006 00:25:26 +0000 (UTC) From: Jeff Roberson <jeff@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/coda coda_vnops.c src/sys/fs/msdosfs msdosfs_vnops.c src/sys/kern vfs_syscalls.c src/sys/nfsserver nfs_serv.c nfs_srvsubs.c src/sys/ufs/ufs ufs_extattr.c Message-ID: <200602010025.k110PQ6Z092511@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
jeff 2006-02-01 00:25:26 UTC
FreeBSD src repository
Modified files:
sys/coda coda_vnops.c
sys/fs/msdosfs msdosfs_vnops.c
sys/kern vfs_syscalls.c
sys/nfsserver nfs_serv.c nfs_srvsubs.c
sys/ufs/ufs ufs_extattr.c
Log:
- Reorder calls to vrele() after calls to vput() when the vrele is a
directory. vrele() may lock the passed vnode, which in these cases would
give an invalid lock order of child -> parent. These situations are
deadlock prone although do not typically deadlock because the vrele
is typically not releasing the last reference to the vnode. Users of
vrele must consider it as a call to vn_lock() and order it appropriately.
MFC After: 1 week
Sponsored by: Isilon Systems, Inc.
Tested by: kkenn
Revision Changes Path
1.68 +9 -12 src/sys/coda/coda_vnops.c
1.163 +2 -2 src/sys/fs/msdosfs/msdosfs_vnops.c
1.401 +11 -11 src/sys/kern/vfs_syscalls.c
1.162 +37 -38 src/sys/nfsserver/nfs_serv.c
1.138 +1 -1 src/sys/nfsserver/nfs_srvsubs.c
1.84 +1 -1 src/sys/ufs/ufs/ufs_extattr.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602010025.k110PQ6Z092511>