Date: Mon, 26 Dec 2011 01:02:06 -0800 From: Garrett Cooper <yanegomi@gmail.com> To: Doug Barton <dougb@FreeBSD.org> Cc: Pyun Yong-Hyeon <pyunyh@gmail.com>, d@delphij.net, Eygene Ryabinkin <rea@freebsd.org>, Gleb Smirnoff <glebius@FreeBSD.org>, freebsd-rc@freebsd.org Subject: Re: Annoying ERROR: 'wlan0' is not a DHCP-enabled interface Message-ID: <0A59E5CD-3598-41B0-A707-6C5185E80043@gmail.com> In-Reply-To: <4EF833B7.9040704@FreeBSD.org> References: <n2Hlz4MXZMNcNzN56fSf6/or7Ig@YnbH/K3/Y1Z96RV2jTofcGuSPJI> <4EF6401E.3080902@FreeBSD.org> <20111224215649.GA12789@stack.nl> <4EF80CA7.3070303@FreeBSD.org> <ooDmUS7742YMCurT/5XDO19d%2BS4@g5jH1yj%2BTnAiSdLOy3xs5Jutvhc> <4EF82E3B.6040601@FreeBSD.org> <KjrN1twOoYYUBTKZXsHphbGonrU@g5jH1yj%2BTnAiSdLOy3xs5Jutvhc> <4EF833B7.9040704@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Dec 26, 2011, at 12:43 AM, Doug Barton wrote:
> On 12/26/2011 00:40, Eygene Ryabinkin wrote:
>> Doug, how that can be a failure?
>
> How does anything fail? Isn't that why you call it a "failure" instead
> of a "success?"
>
> But if Gleb is right and the problem is new to HEAD, when did it change,
> and why?
226879 rea if [ -z "${rc_force}" ] && ! dhcpif $ifn; then
226879 rea err 1 "'$ifn' is not a DHCP-enabled interface"
226879 rea fi
$ svn log -r 226879
------------------------------------------------------------------------
r226879 | rea | 2011-10-27 23:03:38 -0700 (Thu, 27 Oct 2011) | 10 lines
Fix handling of rc_force in /etc/rc.d/dhclient
Variable 'rc_force' is accessible only at the time of rc_run_command,
so it can't be examined from the script's main code.
Spotted by: hrs
Reviewed by: hrs, des
Approved by: des
MFC after: 2 weeks
------------------------------------------------------------------------
It simply didn't exist before this change; before it was just a 'return 1', which is illegal outside of functions, amongst other things.
So I vote to just remove the message (convert the err 1 to a exit 1) and MFC back to 9.0… please, because this change is present there now.
We can argue about the semantics of rc_quiet later. Tons of people just care about the fact that the message is showing up and don't really care about the semantics.
Thanks,
-Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0A59E5CD-3598-41B0-A707-6C5185E80043>