Date: Thu, 29 Nov 2012 14:01:47 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243665 - head/sbin/dump Message-ID: <20121129120147.GE3013@kib.kiev.ua> In-Reply-To: <201211290516.qAT5GoT5098709@svn.freebsd.org> References: <201211290516.qAT5GoT5098709@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Thu, Nov 29, 2012 at 05:16:50AM +0000, Eitan Adler wrote: > Author: eadler > Date: Thu Nov 29 05:16:50 2012 > New Revision: 243665 > URL: http://svnweb.freebsd.org/changeset/base/243665 > > Log: > Mark non-returning function as such > > PR: bin/172978 > Approved by: cperciva > MFC after: 3 days > > Modified: > head/sbin/dump/dump.h > > Modified: head/sbin/dump/dump.h > ============================================================================== > --- head/sbin/dump/dump.h Thu Nov 29 03:48:39 2012 (r243664) > +++ head/sbin/dump/dump.h Thu Nov 29 05:16:50 2012 (r243665) > @@ -121,7 +121,7 @@ void trewind(void); > void writerec(char *dp, int isspcl); > > void Exit(int status) __dead2; > -void dumpabort(int signo); > +void dumpabort(int signo) __dead2; > void dump_getfstab(void); > > char *rawname(char *cp); What is the goal of this change ? It is arguably backward. There is absolutely no use to mark signal handler as __dead2, and all other uses do not benefit from the redundand declaration. Also, being quite removed from the function definition, there is a chance that some future modification would make the attribute a lie. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlC3TqsACgkQC3+MBN1Mb4gUFACgpYhL1B/3guz8Tlgck1sj4wGn 2ugAoMqd9AWWaF+qby3HusN/pzOGnr3d =kUCf -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121129120147.GE3013>