Date: Thu, 1 Jul 2004 20:16:18 -0700 From: David Schultz <das@FreeBSD.ORG> To: "Christian S.J. Peron" <csjp@FreeBSD.ORG> Cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/libexec/tftpd tftpd.c Message-ID: <20040702031618.GA80812@VARK.homeunix.com> In-Reply-To: <200406301858.i5UIwJkB047720@repoman.freebsd.org> References: <200406301858.i5UIwJkB047720@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jun 30, 2004, Christian S.J. Peron wrote: > csjp 2004-06-30 18:58:19 UTC > > FreeBSD src repository > > Modified files: > libexec/tftpd tftpd.c > Log: > The call to setuid(2) subsequently causes setgroups(2) to fail. setgroups(2) > requires super-user access in order to complete successfully. > Move setgroups(2) to execute before setuid(2) so that it is successful. Error checks would also be appropriate here, and would have caught the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040702031618.GA80812>