Date: Mon, 16 Oct 2006 12:57:01 -0600 (MDT) From: Mike Durian <durian@shadetreesoftware.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: bin/104478: ngctl Makefile doesn't observe NO_LIBPTHREAD Message-ID: <200610161857.k9GIv1A2044803@man.boogie.com> Resent-Message-ID: <200610161910.k9GJAB7Z076708@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 104478 >Category: bin >Synopsis: ngctl Makefile doesn't observe NO_LIBPTHREAD >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Oct 16 19:10:10 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Mike Durian >Release: FreeBSD 6.2-PRERELEASE i386 >Organization: >Environment: System: FreeBSD man.boogie.com 6.2-PRERELEASE FreeBSD 6.2-PRERELEASE #0: Fri Oct 13 10:41:27 MDT 2006 root@man.boogie.com:/usr/obj/usr/src/sys/BOOGIE i386 >Description: I recently updated my kernel and tried to build an image using nanobsd.sh. The build failed with usr.sbin/ngctl, because the Makefile didn't know how to build libpthread. My nanobsd configuration file does define NO_LIBPTHREAD=YES. I believe the ngctl/Makefile 1.14.8.1 change which adds dependancies on libedit and libpthread unless RELEASE_CRUNCH is defined, should also exclude those dependancies if NO_LIBTHREAD is defined. >How-To-Repeat: Define NO_LIBTHREAD=YES in a nanobsd configuration file, or easier, in make.conf. Try to buildworld. >Fix: --- Makefile.orig Mon Oct 16 12:21:11 2006 +++ Makefile Mon Oct 16 12:21:56 2006 @@ -7,7 +7,7 @@ msg.c debug.c shutdown.c rmhook.c status.c types.c write.c WARNS?= 3 -.if defined(RELEASE_CRUNCH) +.if defined(RELEASE_CRUNCH) || defined(NO_LIBPTHREAD) NGCTL_NO_LIBEDIT= .endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200610161857.k9GIv1A2044803>