Date: Sat, 09 Jan 1999 18:54:58 +0900 From: Kazutaka YOKOTA <yokota@zodiac.mech.utsunomiya-u.ac.jp> To: Andrzej Bialecki <abial@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, yokota@zodiac.mech.utsunomiya-u.ac.jp Subject: Re: cvs commit: src/sys/i386/i386 userconfig.c Message-ID: <199901090955.SAA08764@zodiac.mech.utsunomiya-u.ac.jp> In-Reply-To: Your message of "Fri, 08 Jan 1999 13:00:27 PST." <199901082100.NAA29107@freefall.freebsd.org> References: <199901082100.NAA29107@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Since INTOR_USERCONFIG was introduced a couple of months ago, I find the behavior of the UserConfig prompt odd, if not broken. Even if I don't enter UserConfig, I always got "config> quit" as below because userconfig.:getchar() returns "quit" when !RB_CONFIG. I think such echo shouldn't be showing when the user had no intention of running UserConfig in the first place. ----------------------------------------------------------------- CPU: Pentium Pro (686-class CPU) Origin = "GenuineIntel" Id = 0x619 Stepping=9 Features=0xfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,... real memory = 67108864 (65536K bytes) config> quit ~~~~~~~~~~~~ <- I didn't type this; getchar() automatically inserted it! avail memory = 62107648 (60652K bytes) Programming 24 pins in IOAPIC #0 ----------------------------------------------------------------- If I do enter UserConfig by giving -c option to the kernel, I got a banner "FreeBSD Kernel Configuration Utility...", but it shows AFTER the first "config>" prompt. This is slightly annoying. It should be printed BEFORE the "config>" prompt, shouldn't it? ----------------------------------------------------------------- CPU: Pentium Pro (686-class CPU) Origin = "GenuineIntel" Id = 0x619 Stepping=9 Features=0xfbff<FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,... real memory = 67108864 (65536K bytes) config> ~~~~~~~ <- unnecessary prompt FreeBSD Kernel Configuration Utility - Version 1.2 Type "help" for help or "visual" to go to the visual configuration interface (requires MGA/VGA display or serial terminal capable of displaying ANSI graphics). _ <- cursor is here!! ----------------------------------------------------------------- Kazu > Modified files: > sys/i386/i386 userconfig.c > Log: > Fix faulty logic in handling userconfig_script, INTRO_USERCONFIG and > RB_CONFIG. > > Now, the code should do the right thing in the following cases, when > kernel is compiled with INTRO_USERCONFIG: > > * when booted without userconfig_script and without RB_CONFIG, present > intro screen, and wait for user input. > > * when booted with userconfig_script and without RB_CONFIG, DON'T present > intro screen unless explicitly asked in userconfig_script, basing on > assumption that if a user loads userconfig_script, (s)he already > decided what parameters to configure. Proceed with booting. [...] To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199901090955.SAA08764>