Date: Mon, 15 Jan 2007 14:09:37 -0500 From: Randall Stewart <rrs@cisco.com> To: Max Laier <max@love2party.net> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_subr.c src/sys/sys systm.h src/share/man/man9 Makefile hashinit.9 Message-ID: <45ABD171.1050509@cisco.com> In-Reply-To: <200701151933.39686.max@love2party.net> References: <200701151506.l0FF6S6D022659@repoman.freebsd.org> <200701151933.39686.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Max Laier wrote: > On Monday 15 January 2007 16:06, Randall Stewart wrote: > This breaks the tinderbox: >> /src/sys/kern/kern_subr.c: In function `hashinit_flags': >> /src/sys/kern/kern_subr.c:375: warning: suggest parentheses around >> comparison in operand of | *** Error code 1 Yeah, it was the one thing that Robert had me add amongst some other spacing issues. And of course I had already did my make universe on the old version :-0 I have a patch for it.. but am waiting for approval from George :-) > > and why are we useing new flags, btw? Can't we just pass down the normal > malloc flags? I seem to remember that we do that in a couple of places > already. > Well... I was game to either method.. I think the general thought was that there may be OTHER non-memory flags that we direct at hash-init someday.. and having them not locked to memory was a good thing.. Robert might care to comment on this one .. of course it can always be changed to be just the memory flags too :-) R -- Randall Stewart NSSTG - Cisco Systems Inc. 803-345-0369 <or> 803-317-4952 (cell)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?45ABD171.1050509>