Date: Fri, 17 Sep 2010 09:36:13 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: joel@FreeBSD.org Cc: freebsd-current@FreeBSD.org, jhb@FreeBSD.org Subject: Re: Multiple hpet messages during boot Message-ID: <20100917.093613.490009667275365136.imp@bsdimp.com> In-Reply-To: <20100917055953.GF1036@pluto.vnode.local> References: <20100915063233.GE1036@pluto.vnode.local> <201009160828.35520.jhb@freebsd.org> <20100917055953.GF1036@pluto.vnode.local>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20100917055953.GF1036@pluto.vnode.local>
Joel Dahl <joel@FreeBSD.ORG> writes:
: On 16-09-2010 8:28, John Baldwin wrote:
: > On Wednesday, September 15, 2010 2:32:33 am Joel Dahl wrote:
: > > I noticed this during boot (HEAD from yesterday):
: > >
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > > hpet0: [FILTER]
: > >
: > > Is it really necessary to print this 8 times?
: >
: > I'd actually like to remove the interrupt messages that say '[FILTER]' or
: > '[GIANT]', etc. I think in general they only add clutter.
:
: Definitely agreed. Go for it.
so is there support for the following:
Index: subr_bus.c
===================================================================
--- subr_bus.c (revision 212791)
+++ subr_bus.c (working copy)
@@ -3996,9 +3996,11 @@
arg, cookiep);
if (error != 0)
return (error);
+ if (bootverbose == 0)
+ return (0);
if (handler != NULL && !(flags & INTR_MPSAFE))
device_printf(dev, "[GIANT-LOCKED]\n");
- if (bootverbose && (flags & INTR_MPSAFE))
+ if (flags & INTR_MPSAFE)
device_printf(dev, "[MPSAFE]\n");
if (filter != NULL) {
if (handler == NULL)
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100917.093613.490009667275365136.imp>