Date: Sat, 19 Apr 2003 17:52:16 +0100 From: "Andy Gilligan" <andy@evo6.org> To: "Gregory Neil Shapiro" <gshapiro@freebsd.org> Cc: stable@freebsd.org Subject: Re: MFC for sysctl descriptions Message-ID: <000901c30694$091bd010$0a00000a@vx> References: <000801c3067d$b6379340$0a00000a@vx> <20030419161506.GE5607@horsey.gshapiro.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes, it should... I was wondering about this myself. Although, it is also just called 'descr' in -CURRENT, and I was initially unsure if this would have any impact on the rest of the kernel. After delving a little deeper I see no reason for it to be kept as 'descr', so I have modified the patch accordingly. I have just recompiled my own kernel, with the 'oid_descr' field changes and everything seems to be ok. Best regards, - Andy ----- Original Message ----- From: "Gregory Neil Shapiro" <gshapiro@freebsd.org> To: "Andy Gilligan" <andy@evo6.org> Sent: Saturday, April 19, 2003 5:15 PM Subject: Re: MFC for sysctl descriptions > One comment on the patch: > > --- sys/sys/sysctl.h 9 Sep 2002 19:27:54 -0000 1.81.2.9 > +++ sys/sys/sysctl.h 19 Apr 2003 13:24:38 -0000 > @@ -133,6 +133,7 @@ > int (*oid_handler)(SYSCTL_HANDLER_ARGS); > const char *oid_fmt; > int oid_refcnt; > + const char *descr; > }; > > Shouldn't that be oid_descr to match the style of the rest of the > structure elements? >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?000901c30694$091bd010$0a00000a>