Date: Sat, 02 Mar 2013 10:19:32 -0800 From: Kirk McKusick <mckusick@mckusick.com> To: Sergey Kandaurov <pluknet@freebsd.org>, David Wolfskill <david@catwhisker.org> Cc: current@freebsd.org Subject: Re: [PATCH] Fix sbin/fsdb/fsdbutil.c for r247212 Message-ID: <201303021819.r22IJWSA041214@chez.mckusick.com> In-Reply-To: <CAE-mSOJGUjwpQC-Nw_ZrpLA_YK_aQBzQSYeKTCVeaMOEbK0XrA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> Date: Sun, 24 Feb 2013 22:41:21 +0300 > Subject: Re: [PATCH] Fix sbin/fsdb/fsdbutil.c for r247212 > From: Sergey Kandaurov <pluknet@freebsd.org> > To: David Wolfskill <david@catwhisker.org> > Cc: current@freebsd.org, Kirk McKusick <mckusick@freebsd.org> > > On 24 February 2013 19:25, David Wolfskill <david@catwhisker.org> wrote: >> On Sun, Feb 24, 2013 at 07:05:34AM -0800, David Wolfskill wrote: >>> ...hine was: >>> Simple patch attached; world is still building, but at least it got >>> through the "make dependencies" phase this time. >>> ... >> >> That was incomplete, as it didn't (also) address the change to >> getdatablk(). >> >> The attached patch actually made it through buildworld. >> >> Note that it is entirely possible that I erred in specifying >> "BT_UNKNOWN" for the additional "type" argument. > > Hi David. > > Thank you for the proposed fix. I committed it with r247234. > I'm not sure regarding BT_UNKNOWN value either. Well.. at least > it should be not worse that it is now, and it should fix the build. > I have not found any (regressive) changes in fsdb -d `blocks' output. > > -- > wbr, > pluknet Sorry, I am bad about keeping up with my mckusick@freebsd.org email. I do need to watch it right after making commits. I also had no idea that sbin/fsdb shared code with sbin/fsck_ffs. I really do need to get back in the habit of buildworlds before doing any commits. All that said, the changes that you have made are correct. The type is only used for collecting statistics. So, if you do not know the type, using DT_UNKNOWN is correct. If there is ever a desire to collect type-of-I/O statistics in fsdb then that choice will need to be revisited. But, I doubt that type-of-I/O statistics are ever likely to be interesting in fsdb. Kirk McKusick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303021819.r22IJWSA041214>