Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 07 Nov 2009 12:52:11 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        Sam Leffler <sam@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r199018 - head/sys/dev/wpi
Message-ID:  <4AF5DDFB.10107@FreeBSD.org>
In-Reply-To: <4AF5C3C7.1020806@freebsd.org>
References:  <200911071842.nA7IgsNn060380@svn.freebsd.org> <4AF5C3C7.1020806@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler wrote:
> The right thing to do is to set wpi_debug to 0 and leave the messages
> compiled in.

Well as you can see from the diff I did leave the messages in the
source so that anyone who wants to enable debugging again can just
define WPI_DEBUG at build time to get it.

However defining WPI_DEBUG to 0 resulted in the debug messages being
printed on the console again so if I'm understanding what you're
suggesting correctly it seems that it would require a lot more changes
in the code to accomplish. (I did see other examples of what I think
you're suggesting in sys/ but this driver doesn't seem to have that
support.)

If I'm not understanding something or you have a better solution feel
free to implement it. My goal was just to get a less noisy console at
boot time.


Doug

-- 

	Improve the effectiveness of your Internet presence with
	a domain name makeover!    http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4AF5DDFB.10107>