Date: Tue, 21 Jan 2014 15:56:10 -0800 From: Garrett Cooper <yaneurabeya@gmail.com> To: Alan Somers <asomers@freebsd.org> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org> Subject: Re: PATCH: add ATF tests in sys Message-ID: <C2E6F1D5-B409-4F2E-B856-C65473BCC3A0@gmail.com> In-Reply-To: <CAOtMX2iiSH9DvE73_7V=A%2ByqObROmvJu7VRTMG7K74eMtHk4=g@mail.gmail.com> References: <CAOtMX2iiSH9DvE73_7V=A%2ByqObROmvJu7VRTMG7K74eMtHk4=g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jan 21, 2014, at 14:45, Alan Somers <asomers@freebsd.org> wrote: >=20 > I rewrote the unix seqpacket tests in ATF. The hard part is adding > them to the build. The linked patch adds them in the directory > sys/kern/tests and builds them as part of buildworld, not buildkernel. > They get installed to /usr/tests/sys/kern, but the intermediate > objects are stored in /usr/obj/sys/kern/tests. That means that you > can't have different tests associated with different kernel configs. > I think that this is desirable, because you wouldn't be able to > install tests for different kernel configs anyway, given our chosen > layout of /usr/tests. >=20 > Please comment on the parts of this patch that deal with Makefiles. > Is this the appropriate way to add sys tests to the build? Shouldn't > I be building them in buildkernel instead of buildworld? I couldn't > find a good way to do that. I bypassed that for simplicity and placed the tests in tests/sys/kern/... et= c. Shoehorning things into our overly complex kernel build system just seems= like a really bad idea... Just make it load as a driver, loadable, and depe= ndent on kern.features to run..? Cheers! -Garrett=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C2E6F1D5-B409-4F2E-B856-C65473BCC3A0>