Date: Tue, 3 Sep 2019 10:34:35 -0400 From: Shawn Webb <shawn.webb@hardenedbsd.org> To: Justin Hibbits <chmeeedalf@gmail.com> Cc: Brooks Davis <brooks@freebsd.org>, Mateusz Guzik <mjg@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys Message-ID: <20190903143435.27atd53bvyj57sxh@mutt-hbsd> In-Reply-To: <20190903093227.08bfdd8f@ralga.knownspace> References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> <20190903114740.gbzkeffdce3mkee2@mutt-hbsd> <20190903142035.w7tuqow4impv6bkx@mutt-hbsd> <20190903093227.08bfdd8f@ralga.knownspace>
next in thread | previous in thread | raw e-mail | index | archive | help
--ci3vhogmgid7kxkw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Sep 03, 2019 at 09:32:27AM -0500, Justin Hibbits wrote: > On Tue, 3 Sep 2019 10:20:35 -0400 > Shawn Webb <shawn.webb@hardenedbsd.org> wrote: >=20 > > On Tue, Sep 03, 2019 at 07:47:40AM -0400, Shawn Webb wrote: > > > On Tue, Sep 03, 2019 at 11:45:23AM +0000, Brooks Davis wrote: =20 > > > > On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: =20 > > > > > Hey Mateusz, > > > > >=20 > > > > > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: = =20 > > > > > > Author: mjg > > > > > > Date: Tue Sep 3 04:16:30 2019 > > > > > > New Revision: 351729 > > > > > > URL: https://svnweb.freebsd.org/changeset/base/351729 > > > > > >=20 > > > > > > Log: > > > > > > Add sysctlbyname system call > > > > > > =20 > > > > > > Previously userspace would issue one syscall to resolve the > > > > > > sysctl and then another one to actually use it. Do it all in > > > > > > one trip.=20 > > > > > > Fallback is provided in case newer libc happens to be > > > > > > running on an older kernel. > > > > > > =20 > > > > > > Submitted by: Pawel Biernacki > > > > > > Reported by: kib, brooks > > > > > > Differential Revision: > > > > > > https://reviews.freebsd.org/D17282 > > > > > >=20 > > > > > > Modified: =20 > > > > > ... snip ... =20 > > > > > > head/sys/sys/param.h =20 > > > > >=20 > > > > > ... snip ... > > > > > =20 > > > > > >=20 > > > > > > Modified: head/sys/sys/param.h > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > > > > > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 > > > > > > 2019 (r351728) +++ head/sys/sys/param.h Tue Sep > > > > > > 3 04:16:30 2019 (r351729) @@ -60,7 +60,7 @@ > > > > > > * in the range 5 to 9. > > > > > > */ > > > > > > #undef __FreeBSD_version > > > > > > -#define __FreeBSD_version 1300044 /* Master, > > > > > > propagated to newvers */ +#define __FreeBSD_version > > > > > > 1300045 /* Master, propagated to newvers */ =20 > > > > >=20 > > > > > To an outsider, it seems that __FreeBSD_version tends to be > > > > > bumped in a separate commit. Am I remembering that right? =20 > > > >=20 > > > > It should be bumped in the same commit, but people forget or the > > > > bump they have in their review turns into a no-op because someone > > > > else does a bump in the interim (the latter has bit me several > > > > times). =20 > > >=20 > > > Interesting. Thanks for the clarification! =20 > >=20 > > One thought for making the version bump a seperate commit is if the > > original commit needed to be reverted, the commit can be reverted > > wholesale (well, from the perspective of __FreeBSD_version) without > > worry of accidentally decrementing the version number to a prior > > value. > >=20 > > That's my "need-more-caffeine" verbose way of saying "separating the > > version bump from the actual work allows for easier maintenance of the > > version number, helping ensure an always-increasing number." > >=20 > > Sorry if I sound dry here. My ten-month-old puppy is tiring me out way > > faster than I can tire him out. > >=20 > > Thanks, > >=20 >=20 > I always thought convention was separate commits to ease MFCs. The few > times I've bumped __FreeBSD_version I've done it explicitly as a > followup commit for that reason. Guess I now know better :) I should also note that I'm looking at this from an outsider's perspective, which may not reflect the same perspective as an insider's. :) --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --ci3vhogmgid7kxkw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl1uefYACgkQ/y5nonf4 4fqU1w//TUBQ3MDeNWWBhcXwreEtxgQ3EBCMV3wzU+HgdPJgAcDTIDG/B97WGuRn vk6s+92MDmrFU89IxdnLAg9YuvnuHQaSzj1G+P1yLkivuqn+gzydSm2krp/1cLx2 CmCN5JCR/J4TcDclnRyUtM7p/BsXUMTt4pPBDnDwV1dlIC57eaGwZrH3cxtjf6Pl BncjZ/FSJualpT/k7FHpaagoVy8wKkV4/IkT2uwsD92Fl2FE7AT1GByC3dkjV+oi nUSDShXhKL5O8yjsXBlZDq1PBgo3sRHPZMmR15esdFFrXeBe+Hv4p/Kbl+o6R55Z l0gVIANgJTwuFy/y1MLLhW2Q+BcBeL2Py/3ok5QR5fRzUIMtTuBQiArQd6mAH74w f3e7S2917hGXsElNfXH69etJ/gt41rMMlL/voVHRHT7WHyMzEt4uv9IzYToIXxhL R7ROkCscKS2s5JZ9LzK7zQNRLed0fAXKKMTBEHf0FpELYkSk6JUNEcilliOHRiuD EGXhiCWdL0PflrNhWiw46XXn5cnCHs4GG5YGx5YLOUoc/umr0QFTZvKVUSrH6whW cCjPqyu0IvBlvQLWGgL8I61oG9X9FctaMVOv51ZV9o8WqmnYxDP8slznH52MCGhK c3oCMj4XcKKZU6HFbUhbfuBdzWwfPSzrmMKj5Irojvmu++aqtw0= =gDYP -----END PGP SIGNATURE----- --ci3vhogmgid7kxkw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190903143435.27atd53bvyj57sxh>