Date: Thu, 29 Nov 2012 15:04:49 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Eitan Adler <eadler@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r243665 - head/sbin/dump Message-ID: <20121129130449.GH3013@kib.kiev.ua> In-Reply-To: <CAF6rxgmmH6Q2N-NOFywaxjyCVrijUc7CSTdHC%2BJaeu3DM_e3CQ@mail.gmail.com> References: <201211290516.qAT5GoT5098709@svn.freebsd.org> <20121129120147.GE3013@kib.kiev.ua> <CAF6rxgmmH6Q2N-NOFywaxjyCVrijUc7CSTdHC%2BJaeu3DM_e3CQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--7e8BFhNxqpjiNKz7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 29, 2012 at 07:45:12AM -0500, Eitan Adler wrote: > On 29 November 2012 07:01, Konstantin Belousov <kostikbel@gmail.com> wrot= e: > > On Thu, Nov 29, 2012 at 05:16:50AM +0000, Eitan Adler wrote: > >> Author: eadler > >> Date: Thu Nov 29 05:16:50 2012 > >> New Revision: 243665 > >> URL: http://svnweb.freebsd.org/changeset/base/243665 > >> > >> Log: > >> Mark non-returning function as such > >> > >> PR: bin/172978 > >> Approved by: cperciva > >> MFC after: 3 days > >> > >> Modified: > >> head/sbin/dump/dump.h > >> > >> Modified: head/sbin/dump/dump.h > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/sbin/dump/dump.h Thu Nov 29 03:48:39 2012 (r243664) > >> +++ head/sbin/dump/dump.h Thu Nov 29 05:16:50 2012 (r243665) > >> @@ -121,7 +121,7 @@ void trewind(void); > >> void writerec(char *dp, int isspcl); > >> > >> void Exit(int status) __dead2; > >> -void dumpabort(int signo); > >> +void dumpabort(int signo) __dead2; > >> void dump_getfstab(void); > >> > >> char *rawname(char *cp); > > What is the goal of this change ? >=20 > It fixes some static analyzer warnings. This cannot be a reason to cripple the code. --7e8BFhNxqpjiNKz7 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJQt11vAAoJEJDCuSvBvK1BOtoP+wUojm+INQ2WCWJIJicFBe6h lRw+a1cJw38Ww/4dAjytL1cQe7vdG9YgJf3MK3+n7ZVDjBRa+TtyZpsR97A6nI8B XHB+Ozl/qGagebrguoOoCy+IYcR04R6E/wC+Q2mxhko7HPzoXZQSUFh+hpkj0BFl xysz4IBHjfXL1kh8r2TPeuSBcd6MQN/xWjmPZZFPIsHcwRAgsTQb+h0a9LrrUfp5 C/3CZPopsuICbwMuLgWiPcliudU0/fdivzoL6snUEzg0EV0g+32w0rPfUU2Jsfin VjEinuYT7M6NZsNv2Scl+xLxaOSQpNKcnz0hWBMFARuLgTVBHt3fBpa6CqKiL2Yy TWUAGdTu9YwbjdjsCJ3eLEe+6n5TijbepK5OvQGYqNRZz3/se0C5cRpYF6318TFD 3o1kXK/eu+aJ93SaJkIbkZmbX6TNXMJRyDpQ+Ik2g0pt4NKOmKcWt9uOySlRTbVx UN8BHU9DxhJz4lR6z/YwlBN4Uu4mmmMF2QsRLcJ7wV4b4qbo6zhd8XFEkNcHESVj JTZlq9ktXAKUd4DnWBiQuZmSn4UbKAWW3f1pjHyDBAcWnoM/y3FnaxgpqoIBStE4 VCF0PfuUoMeOcCZEJohsfsM5BgApq62OOmseisOSzgBWVTeGzvLNvdgMEYe9xdZF elq7gjruUC2jMGPzcOTA =aaDE -----END PGP SIGNATURE----- --7e8BFhNxqpjiNKz7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121129130449.GH3013>