Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 11 Jan 2000 16:03:03 +0100
From:      Marcel Moolenaar <marcel@scc.nl>
To:        "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
Cc:        Brian Feldman <green@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/lib/libncurses Makefile  src/gnu/lib/libdialog         Makefile
Message-ID:  <387B4627.D82F3E98@scc.nl>
References:  <200001111359.FAA24631@gndrsh.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
"Rodney W. Grimes" wrote:
> 
> > green       2000/01/11 04:37:58 PST
> >   The story is that these were added to beforeinstall improperly.  In our
> >   beforeinstall, a full mtree has not been populated.  Since the tree is
> >   not populated, we explode from missing directories on doc install.  It
> >   should not be done in beforeinstall (includes) anyway.
> 
> Given Marcel's work on the the buildworld process does it now make since
> to fix the overloaded use of ``beforeinstall'' to be a few different
> targets.

Yes, please :-)

> IMHO, we should at least split out all the includes into an includes:
> target and stop calling beforeinstall to do this.  (includes: would
> be an internal target, the Makefile would just have INCLUDES=blah blah
> and work something like MANx=, but has the problem of not all headers
> go in a nice simple hierarchy like MAN, perhaps INCLUDEDIR= could be
> used to solve this, perhaps not)

We eventually can do the same for libraries. This also follows how we
build world: includes first, then libraries and finally everything else.

> If we get agreement I'll do the grunt work of the tree sweep to make it
> happen (if Marcel will agree to review the patches :-)).

Sure. Unfortunately I already killed my prototype patch, otherwise you
wouldn't have to do anything. I had changed all those beforeinstall
targets to include(s) targets before :-(

It isn't even on freefall anymore or on any of my backups... damn...

-- 
Marcel Moolenaar                        mailto:marcel@scc.nl
SCC Internetworking & Databases           http://www.scc.nl/
The FreeBSD project                mailto:marcel@FreeBSD.org


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?387B4627.D82F3E98>