Date: Tue, 03 Feb 2026 15:51:16 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: ShengYi Hung <aokblast@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 3e6e4e4a0d42 - main - hwpstate: add CPPC support for pstate driver on AMD Message-ID: <86ms1pdgnv.fsf@ltc.des.dev> In-Reply-To: <6958849c.4623e.7b53a822@gitrepo.freebsd.org> (ShengYi Hung's message of "Sat, 03 Jan 2026 02:53:16 %2B0000") References: <6958849c.4623e.7b53a822@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
ShengYi Hung <aokblast@FreeBSD.org> writes: > +static bool hwpstate_pkg_ctrl_enable = true; > +SYSCTL_BOOL(_machdep, OID_AUTO, hwpstate_pkg_ctrl, CTLFLAG_RDTUN, > + &hwpstate_pkg_ctrl_enable, 0, > + "Set 1 (default) to enable package-level control, 0 to disable"); This doesn't work. You are reusing the same OID already used by the Intel subdriver. The result is that whichever one happens to be first on the linker command line works and the other one doesn't. You have to either use a different OID for each subdriver or have both subdrivers share a single boolean. DES -- Dag-Erling Smørgrav - des@FreeBSD.orghome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ms1pdgnv.fsf>