Date: Fri, 22 May 1998 11:59:33 +0200 From: Eivind Eklund <eivind@yes.no> To: Bruce Evans <bde@zeta.org.au>, current@FreeBSD.ORG Subject: Re: cvs commit: src/sys/pci if_tl.c if_tlreg.h Message-ID: <19980522115933.24770@follo.net> In-Reply-To: <199805220502.PAA03138@godzilla.zeta.org.au>; from Bruce Evans on Fri, May 22, 1998 at 03:02:51PM %2B1000 References: <199805220502.PAA03138@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 22, 1998 at 03:02:51PM +1000, Bruce Evans wrote:
> >> > No, no, no. Create an osreldate.h file instead. Please? Using __FreeBSD__
> >> > doesn't work because it's tied to the compiler, not the source.
>
> No. Neither should be used.
If we want anybody external to FreeBSD to develop drivers (and I know _I_
do, at least) then we need to provide such a mechanism. Presently they use
the value of __FreeBSD__, which is even more unsatifactory than
__FreeBSD_version.
> >That was the change I installed and backed out so fast earlier today;
> >it unfortunately didn't work.
>
> Fortunately :-).
If you didn't want __FreeBSD_version moved to param.h, you had every chance
to object when I sent the proposal to -current - it had a very clear subject
("__FreeBSD_version -> param.h", I think). Right now that change is active
in the tree (as I had time to fix it today).
> >> did. If this is really a step forward then I'd suggest that
> >> a whole lot more needs changing if self-consistency is also your
> >> goal (and I think it should be, especially where this kind of
> >> stuff is concerned, since other driver writers will imitate it).
>
> It's a step backwards. We use cvs for version control here.
We're talking external drivers. I'm in favour of removing all #ifdefs for
versions/systems from the FreeBSD tree, as long as it can be done in an
automated fashion before each new import (I'm not certain how well unifdef
handles the task - I've not looked at it).
Eivind.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980522115933.24770>