Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 29 May 2013 13:22:06 +0200
From:      Dimitry Andric <dim@FreeBSD.org>
To:        Adrian Chadd <adrian@FreeBSD.org>, src-committers@freebsd.org,  svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r251098 - head/sys/contrib/dev/ath/ath_hal/ar9300
Message-ID:  <51A5E4DE.5060007@FreeBSD.org>
In-Reply-To: <201305290421.r4T4LgRc099595@svn.freebsd.org>
References:  <201305290421.r4T4LgRc099595@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2013-05-29 06:21, Adrian Chadd wrote:
> Author: adrian
> Date: Wed May 29 04:21:42 2013
> New Revision: 251098
> URL: http://svnweb.freebsd.org/changeset/base/251098
>
> Log:
>    Fix a false -> AH_FALSE.
>
>    Now, why this hasn't tripped _any_ tinderbox builds yet, I dunno.
>    It's been like this for a while.

Because 'false' will be implicitly converted to an enum HAL_BOOL value.
Adding a warning for such cases would result in a *lot* of noise, and
probably many angry developers. ;-)

Note that in C++, such a call would result in an error: "no known
conversion from 'bool' to 'HAL_BOOL'".




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?51A5E4DE.5060007>