Date: Tue, 10 Sep 2002 19:05:25 +1000 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jon Mini <mini@FreeBSD.org> Cc: Juli Mallett <jmallett@FreeBSD.org>, John Baldwin <jhb@FreeBSD.org>, <cvs-all@FreeBSD.org>, <cvs-committers@FreeBSD.org> Subject: Re: cvs commit: src/lib/libc/gen siglist.c Message-ID: <20020910185546.T596-100000@gamplex.bde.org> In-Reply-To: <20020910031104.GA39524@elvis.mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 9 Sep 2002, Jon Mini wrote:
> Juli Mallett [jmallett@FreeBSD.org] wrote :
>
> > * De: John Baldwin <jhb@FreeBSD.org> [ Data: 2002-09-09 ]
> > [ Subjecte: RE: cvs commit: src/lib/libc/gen siglist.c ]
> > >
> > > On 07-Sep-2002 Juli Mallett wrote:
> > > > jmallett 2002/09/07 01:14:19 PDT
> > > >
> > > > Modified files:
> > > > lib/libc/gen siglist.c
> > > > Log:
> > > > Two arrays were born from the same seeds, both grew into complementary sets
> > > > of pointers to strings. These two arrays were fixed to the same size, but one
> > > > had an implicit zeroed trailer element, which was unused because the size was
> > > > used up by the ones before said zeroed trailer element. So the unused limb was
> > > > chopped off the over-sized-but-not-over-sized array, and everyone lived happily
> > > > ever after.
> > >
> > > What does this mean in practical terms?
> >
> > I removed a comma.
>
> *HAHAHAHAHAHAHAHAHAHAHAHA*
I would have worded the log message a little differently:
Add a style bug to the declaration of sys_signame[] to make it bug for
bug compatible with the declaration of sys_siglist[] :-).
(The declaration of sys_signame[] used the technique of having an
unnecessary comma at the end of the list to make the list easier to
extend, but the declaration of sys_siglist[] didn't. IMO, not using
this comma is a style bug except for the small set of array initializers
that will never be extended. BTW, C99 fixed the corresponding
design-style bug for enums -- C99 code can use this comma at the end
of enum lists.)
Bruce
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020910185546.T596-100000>