Date: Wed, 16 Jun 2010 16:13:55 +0200 From: Rafal Jaworowski <raj@semihalf.com> To: Andrew Turner <andrew@fubar.geek.nz> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r209129 - head/sys/arm/arm Message-ID: <B3697DEE-6BB0-45D0-8B01-B8809600C238@semihalf.com> In-Reply-To: <20100616210344.47209ff2@bender> References: <201006131308.o5DD8NTA033564@svn.freebsd.org> <20100616210344.47209ff2@bender>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2010-06-16, at 11:03, Andrew Turner wrote: > On Sun, 13 Jun 2010 13:08:23 +0000 (UTC) > Rafal Jaworowski <raj@FreeBSD.org> wrote: >=20 >> Author: raj >> Date: Sun Jun 13 13:08:23 2010 >> New Revision: 209129 >> URL: http://svn.freebsd.org/changeset/base/209129 >>=20 >> Log: >> Improve style. >>=20 >> Modified: >> head/sys/arm/arm/nexus.c >>=20 >> Modified: head/sys/arm/arm/nexus.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/arm/arm/nexus.c Sun Jun 13 13:02:43 2010 >> (r209128) +++ head/sys/arm/arm/nexus.c Sun Jun 13 13:08:23 >> 2010 (r209129) @@ -107,6 +107,7 @@ static devclass_t >> nexus_devclass; static int >> nexus_probe(device_t dev) >> { >> + >> device_quiet(dev); /* suppress attach message for >> neatness */=20 >> mem_rman.rm_start =3D 0; >> @@ -116,7 +117,7 @@ nexus_probe(device_t dev) >> if (rman_init(&mem_rman) || rman_manage_region(&mem_rman, 0, >> ~0u)) panic("nexus_probe mem_rman"); >>=20 >> - return (0); >> + return (BUS_PROBE_DEFAULT); > Changing the return value of nexus_probe from 0 to BUS_PROBE_DEFAULT > causes the following panic for me when the s3c24x0 driver calls > rman_init. The attached patch fixes it by moving the call to rman_init > from nexus_probe to nexus_attach. Thanks (and sorry for the breakage -- it wasn't seen on FDT-enabled = platforms as they use their own rman(s)..), should be fixed in r209232. Rafal
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B3697DEE-6BB0-45D0-8B01-B8809600C238>