Date: Wed, 22 Jun 2005 09:20:16 -0700 (PDT) From: Mohan Srinivasan <mohan_srinivasan@yahoo.com> To: Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw>, khetan@os.org.za Cc: current@freebsd.org Subject: Re: Panic potentially related to imgacct_shell.c commit Message-ID: <20050622162016.25392.qmail@web80602.mail.yahoo.com> In-Reply-To: <05062219434218.29380@www.mmlab.cse.yzu.edu.tw>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
Committing a fix for this issue to -current shortly (today).
In the meantime, you can apply this change to your tree.
==== //depot/mohans/freebsd6_nfs/sys/netinet/tcp_sack.c#18 -
/homes/mohans/p4/mohans/freebsd6_nfs/sys/netinet/tcp_sack.c ====
@@ -474,8 +474,7 @@
* Since the incoming sack blocks are sorted, we can process them
* making one sweep of the scoreboard.
*/
- while (sblkp - sack_blocks >= 0) {
- KASSERT(cur != NULL, ("cur != NULL"));
+ while (sblkp - sack_blocks >= 0 && cur != NULL) {
if (SEQ_GEQ(sblkp->start, cur->end)) {
/*
* SACKs data beyond the current hole.
thanks
mohan
--- Tai-hwa Liang <avatar@mmlab.cse.yzu.edu.tw> wrote:
> On Tue, 21 Jun 2005, Khetan Gajjar wrote:
> [...]
> > (kgdb) backtrace
> > 165 __asm __volatile("movl %%fs:0,%0" : "=r" (td));
> > #0 doadump () at pcpu.h:165
> > #1 0xc04f9568 in boot (howto=260) at ../../../kern/kern_shutdown.c:397
> > #2 0xc04f987d in panic (fmt=0xc069d6ac "cur != NULL")
> > at ../../../kern/kern_shutdown.c:553
> > #3 0xc0593a4c in tcp_sack_option (tp=0xc23c0730, th=0xd4400aac,
> > cp=0xc242da66
>
"\005\022\002Nu\020\002Nz\223\002N\200\026\002N¬.\223¦T\222!¸Ï+zYã¬+<Û\031\016Öñêî1£\006\177~\017A·\221æºu\227$Ñ9Tõ\232ÿ\003\024\234îÅs¦a\206¨e\236ôLZÔï\r]
> imapd[8272]: login: dustpuppy.is.co.za[19", optlen=0)
> > at ../../../netinet/tcp_sack.c:478
> > #4 0xc0591a3b in tcp_dooptions (tp=0xc23c0730, to=0xd4400bb4,
> > cp=0xc242da66
>
"\005\022\002Nu\020\002Nz\223\002N\200\026\002N¬.\223¦T\222!¸Ï+zYã¬+<Û\031\016Öñêî1£\006\177~\017A·\221æºu\227$Ñ9Tõ\232ÿ\003\024\234îÅs¦a\206¨e\236ôLZÔï\r]
> imapd[8272]: login: dustpuppy.is.co.za[19", cnt=18, is_syn=0,
> > th=0xc242da44) at ../../../netinet/tcp_input.c:2647
>
> Try "sysctl net.inet.tcp.sack.enable=0" to see if that helps.>
_______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050622162016.25392.qmail>