Date: Wed, 2 Oct 2002 19:09:55 -0400 From: Mike Barcroft <mike@FreeBSD.org> To: luigi@FreeBSD.org Cc: current@FreeBSD.org Subject: Re: Fatal warnings breaks ipfw on LP64 Message-ID: <20021002190955.D90848@espresso.q9media.com> In-Reply-To: <20020902124032.D94253@espresso.q9media.com>; from mike@FreeBSD.org on Mon, Sep 02, 2002 at 12:40:32PM -0400 References: <20020902124032.D94253@espresso.q9media.com>
next in thread | previous in thread | raw e-mail | index | archive | help
It's been one month, have you made any progress on this? Mike Barcroft <mike@FreeBSD.org> writes: > > cc1: warnings being treated as errors > /usr/src/sys/netinet/ip_fw2.c: In function `ipfw_ctl': > /usr/src/sys/netinet/ip_fw2.c:2508: warning: cast from pointer to integer of different size > /usr/src/sys/netinet/ip_fw2.c:2521: warning: cast from pointer to integer of different size > > Some of the code in question looks questionable: > /* > * abuse 'next_rule' to store the set_disable word > */ > (u_int32_t)(((struct ip_fw *)bp)->next_rule) = > set_disable; > > The rvalue is being cast in an assignment to make a pointer store an > integer? Surely this can be written better. > > Best regards, > Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021002190955.D90848>