Date: Thu, 2 Sep 2010 21:53:02 +0200 From: Attilio Rao <attilio@freebsd.org> To: Ed Maste <emaste@freebsd.org> Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org, Ryan Stone <rysto32@gmail.com> Subject: Re: svn commit: r212142 - in projects/sv/sys: amd64/amd64 arm/arm geom i386/i386 ia64/ia64 net powerpc/powerpc sparc64/sparc64 sun4v/sun4v sys Message-ID: <AANLkTimLUos3U54yctG9V9nSDMB%2BF=bQxVdoLE963%2ByV@mail.gmail.com> In-Reply-To: <20100902194309.GA36288@sandvine.com> References: <201009020933.o829XmS9098339@svn.freebsd.org> <AANLkTi=%2Bh-Pm%2BncXekd4-B6sc5nzKy9Hf8p1pY2RmOCZ@mail.gmail.com> <20100902194309.GA36288@sandvine.com>
index | next in thread | previous in thread | raw e-mail
2010/9/2 Ed Maste <emaste@freebsd.org>: > On Thu, Sep 02, 2010 at 10:35:13AM -0400, Ryan Stone wrote: > >> On Thu, Sep 2, 2010 at 5:33 AM, Attilio Rao <attilio@freebsd.org> wrote: >> > Log: >> > Introduce a flag field for the dumpers and use it immediately for the >> > DIF_NET flag. >> > This flag is responsible for toggling a netdump and having a correct set >> > of dumplo in the dumping routines. >> > >> >> To be honest, I'd be happier if the DIF_NET flag disappeared entirely. >> It seems to me that dumpsys shouldn't need knowledge of disk geometry >> -- especially now when there may not be a disk at all. It seems to me >> that the correct interface would be for dumpsys to pass the offset >> into the core file to the dumper, and the dumper should convert that >> to a value appropriate for the dump device. > > I agree; in fact, on my ToDo list I've got: > > 14. dump_write API change to take offset (and add di->mediaoffset itself) > * makes netdumping slightly cleaner > > If this is the only use of DIF_NET flag then we certainly should be > able to get rid of it. Yes, I think that it should be eas(ish)y to do and I think it is a good idea. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einsteinhelp
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimLUos3U54yctG9V9nSDMB%2BF=bQxVdoLE963%2ByV>