Date: Tue, 26 Jan 2010 14:28:03 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Dag-Erling Sm??rgrav <des@des.no> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Jung-uk Kim <jkim@FreeBSD.org> Subject: Re: svn commit: r198858 - in head/sys: dev/fb dev/syscons sys Message-ID: <20100126142803.GA55760@FreeBSD.org> In-Reply-To: <86ljflj798.fsf@ds4.des.no> References: <200911032022.nA3KM96H003434@svn.freebsd.org> <20100125192941.GA9196@FreeBSD.org> <86ljflj798.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 26, 2010 at 03:00:35PM +0100, Dag-Erling Sm??rgrav wrote: > Alexey Dokuchaev <danfe@FreeBSD.org> writes: > > Apparently this revision broke logo screen saver w/ vesa.ko on i386 (it > > works, but image is significantly darker). > > A darker image indicates that the BIOS is in 8-bit mode but the driver > thinks it's in 6-bit mode, so the driver right-shifts the palette > entries by two bits. Yup, I eventually started to think this is the case after reading through the code and the patch jkim@ sent me privately (which fixed the issue). Considering number of recent vesa/saver breaks, I am thinking about some regression test suit that could at least check for "8-bit vs. 6-bit" type of things. Is it feasible? ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100126142803.GA55760>