Date: Tue, 2 Feb 2021 08:53:46 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Mateusz Guzik <mjg@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: Re: git: e92ab3adf4f9 - stable/13 - atomic: make atomic_store_ptr type-aware Message-ID: <c8bd7ad4-0fa7-b75d-c2e2-84cd0930257b@FreeBSD.org> In-Reply-To: <202102011240.111CehGE094845@gitrepo.freebsd.org> References: <202102011240.111CehGE094845@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/1/21 4:40 AM, Mateusz Guzik wrote: > The branch stable/13 has been updated by mjg: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e92ab3adf4f9848933439c9c2fca36df290c0884 > > commit e92ab3adf4f9848933439c9c2fca36df290c0884 > Author: Mateusz Guzik <mjg@FreeBSD.org> > AuthorDate: 2021-01-25 19:39:14 +0000 > Commit: Mateusz Guzik <mjg@FreeBSD.org> > CommitDate: 2021-02-01 12:39:16 +0000 > > atomic: make atomic_store_ptr type-aware > > (cherry picked from commit cc96f92a570e05636a20fdd15d4616b127bb9ecc) A couple of folks expressed concerns about this commit when it landed in main due to it being too flexible (it allows you to store pointers to non-pointer types, e.g.: char c; uintptr_t p; atomic_store_ptr(&c, p); Silently becomes: atomic_store_char(&c, (char)p); Are you planning to address this? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c8bd7ad4-0fa7-b75d-c2e2-84cd0930257b>