Date: Fri, 14 Mar 2008 03:31:52 +0200 From: Giorgos Keramidas <keramida@ceid.upatras.gr> To: Mike Telahun Makonnen <mtm@FreeBSD.Org> Cc: Gregory Shapiro <gshapiro@FreeBSD.Org>, current@FreeBSD.Org Subject: Re: latest rc.subr breaks etc/rc.d/sendmail Message-ID: <20080314013152.GA3585@kobe.laptop> In-Reply-To: <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com> References: <20080202012707.GA1800@kobe.laptop> <1204809780.885.3.camel@sol> <20080306201905.GA11317@kobe.laptop> <20080311025333.GF2422@monkeyboy.local> <584bfc3f0803122336r96f4033pc0e25a7324fb0486@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2008-03-13 09:36, Mike Telahun Makonnen <mtm@FreeBSD.Org> wrote: > On Tue, Mar 11, 2008 at 5:53 AM, Gregory Shapiro <gshapiro@freebsd.org> wrote: > > > Agreed. We should probably consult gshapiro about this, and just do it > > > if there's no objection. AFAIK, /etc/rc.d/sendmail is also used to > > > start alternative MTAs, so we can commit this patch for now, and think > > > about splitting /etc/rc.d/sendmail to something like: > > > > > > src/etc/rc.d/sendmail > > > src/etc/rc.d/sendmail-submit > > > src/etc/rc.d/sendmail-outbound > > > src/etc/rc.d/sendmail-msp-queue > > > > I'd be cool with this and more than happy to provide code review. > > The four scripts would all need the same sort of logic to disable > > conflicting options (e.g., don't start a submit agent if a full MTA is > > running). > > Can yoiu take a look at the following patch please? It splits out > rc.d/sendmail into its constituent parts. I've split out the logic to > sort out conflicting options and rebuild the aliases database into a > separate file in /etc/mail/sendmail.subr. The rc.d scripts simply call > the appropriate routines in this file. In addition I've kept > rc.d/sendmail but added the nostart keyword. Thanks Mike :-) This looks great, from a fast reading I did. I'll install it on my laptop and test it for a while. If I don't get back to you in 1-2 days, please ping me again. It's a relatively hectic week at work, so it may take a few rc.d/sendmail start/stop iterations before I can fully test this.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080314013152.GA3585>