Date: Wed, 30 May 2018 08:02:12 +0000 From: Antoine Brodin <antoine@freebsd.org> To: Hans Petter Selasky <hps@selasky.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334277 - in head: contrib/libpcap contrib/ofed/usr.lib/3 contrib/pf/pflogd contrib/wpa/src/l2_packet lib lib/libpcap share/mk usr.sbin/cxgbetool Message-ID: <CAALwa8kMsiLxaaRgfw-qGrSfZhv2ov9wj_K3fEtRkqUnG7o0YQ@mail.gmail.com> In-Reply-To: <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org> References: <201805280812.w4S8CI56046943@repo.freebsd.org> <CAALwa8n-UUS8kHmWpiGxKGBWbu4epzTCeusMPg9-FpyMaWS%2BGw@mail.gmail.com> <383666b1-06a9-ac96-812f-c602c8e5e5af@selasky.org> <21342cd6-bf7e-263f-f077-2e073fe9ebef@selasky.org> <CAALwa8nEAh0Xny8_YF%2B4bdCU7tDQo84-kJBcot6ZPAg9Zi9TDg@mail.gmail.com> <1cbed89b-e485-7f15-d3ab-f018024203eb@selasky.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, May 30, 2018 at 7:52 AM, Hans Petter Selasky <hps@selasky.org> wrote: > On 05/30/18 09:36, Antoine Brodin wrote: >> >> On Wed, May 30, 2018 at 7:31 AM, Hans Petter Selasky <hps@selasky.org> >> wrote: >>> >>> On 05/30/18 09:04, Hans Petter Selasky wrote: >>>> >>>> >>>> On 05/30/18 08:04, Antoine Brodin wrote: >>>>> >>>>> >>>>> On Mon, May 28, 2018 at 10:12 AM, Hans Petter Selasky >>>>> <hselasky@freebsd.org> wrote: >>>>>> >>>>>> >>>>>> Author: hselasky >>>>>> Date: Mon May 28 08:12:18 2018 >>>>>> New Revision: 334277 >>>>>> URL: https://svnweb.freebsd.org/changeset/base/334277 >>>>>> >>>>>> Log: >>>>>> MFV r333789: libpcap 1.9.0 (pre-release) >>>>>> >>>>>> MFC after: 1 month >>>>>> Sponsored by: Mellanox Technologies >>>>> >>>>> >>>>> >>>>> Hi, >>>>> >>>>> Some things seem to be missing. >>>>> For instance, pcap_setsampling and pcap_open are now declared in >>>>> pcap.h but they are not compiled in libpcap.so. >>>>> net/p5-Net-Pcap is confused by this: >>>>> >>>>> >>>>> http://gohan2.ysv.freebsd.org/data/head-amd64-default-baseline/p471115_s334360/logs/errors/p5-Net-Pcap-0.18.log >>>> >>>> >>>> >>> >>> Hi, >>> >>> net/p5-Net-Pcap is supposed to depend on and use net/libpcap which >>> install >>> into /usr/local/lib and /usr/local/include from what I understand. >> >> >> No, it worked fine with libpcap from base previously. >> pcap/pcap.h now exposes functions from pcap-new.c but pcap-new.c is >> not compiled. > > > Hi, > > pcap-new.c is only compiled if libpcap should have remote support, which the > in-base library didn't have? > > Can you try to modify the net/p5-Net-Pcap Makefile like this: > > BUILD_DEPENDS= p5-IO-Interface>=0:net/p5-IO-Interface \ > libpcap>=0:net/libpcap > > CFLAGS+= -I${PREFIX}/include > LDFLAGS+= -L${PREFIX}/lib Could the pcap/pcap.h header be fixed instead with #ifdef HAVE_REMOTE as it previously had? Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8kMsiLxaaRgfw-qGrSfZhv2ov9wj_K3fEtRkqUnG7o0YQ>