Date: Wed, 16 Nov 2011 17:49:42 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jan Beich <jbeich@tormail.net> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/lang/s9fes Makefile Message-ID: <20111116174942.GA81352@FreeBSD.org> In-Reply-To: <1RQicz-000NXY-MJ@internal.tormail.net> References: <201111161607.pAGG7trI042076__6520.72345042161$1321459728$gmane$org@repoman.freebsd.org> <1RQicz-000NXY-MJ@internal.tormail.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 16, 2011 at 09:43:07AM -0700, Jan Beich wrote:
> Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> >
> > Modified files:
> > lang/s9fes Makefile
> > Log:
> > Instead of marking this port as make jobs (-jX) unsafe, apply a trivial
> > fix and also properly respect CC, CFLAGS, PREFIX, and LIBDIR.
>
> TIMTOWTDI, one can just pass everything from MAKE_ENV
>
> MAKE_ARGS= ${MAKE_ENV}
> LIBDIR= ${DATADIR}
>
> It has slight advantage of proper quoting, e.g. when ${CC} contains
> distcc/ccache + compiler separated by space.
Thanks for suggestion, I will evaluate it tomorrow and quite probably commit.
All I can say right now is that I'm not sure that passing full-blown
MAKE_ENV as MAKE_ARGS is necessary, since obvious CC quoting issues can be
trivially fixed by, hm, quoting it in place.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20111116174942.GA81352>