Date: Sat, 31 Jul 2021 00:16:00 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 256187] [NEW-PORT] www/py-django-ckeditor: Django admin CKEditor integration Message-ID: <bug-256187-21822-h0nE2khwmS@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-256187-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-256187-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256187 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |maintainer-feedback?(gettok | |nowmi@yahoo.com) Summary|[NEW-PORT] |[NEW-PORT] |www/py-django-ckeditor: |www/py-django-ckeditor: |Django ckeditor version 6 |Django admin CKEditor | |integration Keywords| |needs-patch CC| |gettoknowmi@yahoo.com Severity|Affects Some People |Affects Only Me --- Comment #3 from Kubilay Kocak <koobs@FreeBSD.org> --- Review items: - Latest upstream version is 6.1.0 - Add python to CATEGORIES - Match COMMENT to upstream description (setup.py:description). "Django ad= min CKEditor integration" - Match upstream dependency <versions-specs> ("django-js-asset>=3D1.2.2",) - ",run" is incorrect for most python package cases. It excludes "build" (= 'run time *only*), which is required to compile py files to pyo pyc counterparts= .=20 - Upstream is only testing Python 3.6+, this port declares 3.4+ support. T= his isd fine if the packages tests pass with all allowed versions. - Upstream ships tests. Add TEST_DEPENDS and a test-target for comprehensi= ve QA: Note #1: we don't need to run tox, coverage or lint tests, the following two should be sufficient: TEST_ENV+=3DDJANGO_SETTINGS_MODULE=3Dckeditor_demo.settings ${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py test ckeditor_demo=20 ${SETENV} ${TEST_ENV} ${PYTHON_CMD} manage.py validate_templates Note 2: There are a few more dependencies for tests (pillow, django_extensions). Only add compulsory ones. Interesting to note that these deps arent in install_requires. Are they 'optional' ? Maybe its worth having OPTIONS for these. Confirmation that the port passes tests (portlint, poudriere) would also be great. --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256187-21822-h0nE2khwmS>