Date: Thu, 29 May 2008 17:52:23 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Andrew Thompson <thompsa@FreeBSD.org> Cc: current@FreeBSD.org Subject: Re: ndis(4) patch to replace obsolete if_watchdog interface Message-ID: <1212097943.1681.12.camel@localhost> In-Reply-To: <20080529214604.GA68753@citylink.fud.org.nz> References: <1212093692.1681.8.camel@localhost> <20080529214604.GA68753@citylink.fud.org.nz>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Thu, 2008-05-29 at 14:46 -0700, Andrew Thompson wrote: > On Thu, May 29, 2008 at 04:41:32PM -0400, Coleman Kane wrote: > > Hi, > > > > I just replaced the obsoleted if_watchdog interface in ndis(4) with a > > local implementation. This should remove the obnoxious warning message > > on device init. Anyone using -CURRENT with an ndis card, could you send > > me success/fails? > > > > The patch is here: > > * http://people.freebsd.org/~cokane/patches/if_ndis-new_wd.patch > > > This works different to the rest of the network drivers. The existing > drivers use a callout tick that runs while the driver is up and an > integer counter. > > if (x && --x == 0) > ...timeout... > > You arm the callout and stop it after each Tx, does this have any > perfornace impact? > > > Andrew You are probably right, I'll look into what I can do to re-work it here... I just ran through to perform a naive if_watchdog-->callout_* conversion on this really quickly. Using it, I don't see much of a performance impact. However, I am not using this on a server and CPUFREQ >> NETFREQ for me. -- Coleman Kane [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (FreeBSD) iEYEABECAAYFAkg/JZUACgkQcMSxQcXat5dYcwCfdOaqhqQoWUxVjylXDuDUG6aA jXgAnA/KZxoAcUpBl4emiNweLzvZW36U =OZGY -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1212097943.1681.12.camel>