Date: Tue, 14 Aug 2018 08:28:08 -0700 (PDT) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: Mark Johnston <markj@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337758 - head/sys/x86/x86 Message-ID: <201808141528.w7EFS8db042920@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201808141450.w7EEo78r029739@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> Author: markj > Date: Tue Aug 14 14:50:06 2018 > New Revision: 337758 > URL: https://svnweb.freebsd.org/changeset/base/337758 > > Log: > Explain why we aren't using memcpy(). > > Reported by: jmg > X-MFC with: r337715 > Sponsored by: The FreeBSD Foundation > > Modified: > head/sys/x86/x86/ucode.c > > Modified: head/sys/x86/x86/ucode.c > ============================================================================== > --- head/sys/x86/x86/ucode.c Tue Aug 14 14:19:57 2018 (r337757) > +++ head/sys/x86/x86/ucode.c Tue Aug 14 14:50:06 2018 (r337758) > @@ -344,6 +344,7 @@ ucode_load_bsp(uintptr_t free) > match = loader->match(fileaddr, &len); > if (match != NULL) { > addr = map_ucode(free, len); > + /* We can't use memcpy() before ifunc resolution. */ NVM my previous email, and thank you. > for (i = 0; i < len; i++) > addr[i] = match[i]; > match = addr; -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201808141528.w7EFS8db042920>