Date: Wed, 22 Dec 2010 12:15:12 -0700 From: Warner Losh <imp@bsdimp.com> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Nathan Whitehorn <nwhitehorn@FreeBSD.org> Subject: Re: svn commit: r216662 - head/share/mk Message-ID: <4D124E40.4080305@bsdimp.com> In-Reply-To: <20101222161723.T6126@maildrop.int.zabbadoz.net> References: <201012221459.oBMExM94017630@svn.freebsd.org> <20101222161723.T6126@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/22/2010 09:18, Bjoern A. Zeeb wrote: > On Wed, 22 Dec 2010, Nathan Whitehorn wrote: > >> Author: nwhitehorn >> Date: Wed Dec 22 14:59:22 2010 >> New Revision: 216662 >> URL: http://svn.freebsd.org/changeset/base/216662 >> >> Log: >> Enable build of FDT components by default. dtc is a required build tool >> for all FDT-enabled kernels, and having it off by default means that >> building these kernels fails by default. This fixes FDT-related build >> failures in make universe on ARM and PowerPC. > > Thanks a lot! I wonder if it is arch specific conditional? Is there > any value in having it on non-FDT kernels/architectures? > > I am happily looking forward to a usable universe output again:-)) FDT enables building a tool that is sometimes used when building the kernel. The problem is that it is a cross tool, and building things conditionally based on the architecture for cross tools is not well supported today. The gross hack that attempted to do this was too hard to fix, so it is better to be always on. The resulting bloat is tiny, it can be turned off if you want and it can be made conditional again once we have a better way to specify things like this conditionally. Warner > > >> Reviewed by: imp >> >> Modified: >> head/share/mk/bsd.own.mk >> >> Modified: head/share/mk/bsd.own.mk >> ============================================================================== >> >> --- head/share/mk/bsd.own.mk Wed Dec 22 14:49:18 2010 (r216661) >> +++ head/share/mk/bsd.own.mk Wed Dec 22 14:59:22 2010 (r216662) >> @@ -326,6 +326,7 @@ _clang_no=CLANG >> DICT \ >> DYNAMICROOT \ >> EXAMPLES \ >> + FDT \ >> FLOPPY \ >> FORTH \ >> FP_LIBC \ >> @@ -421,7 +422,6 @@ MK_${var}:= yes >> BIND_XML \ >> BSD_GREP \ >> ${_clang_no} \ >> - FDT \ >> GPIO \ >> HESIOD \ >> IDEA >> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4D124E40.4080305>