Date: Wed, 8 Aug 2018 23:16:20 -0500 From: Kyle Evans <kevans@freebsd.org> To: Warner Losh <imp@bsdimp.com> Cc: Eitan Adler <lists@eitanadler.com>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r337505 - head/bin/dd Message-ID: <CACNAnaEufMXasfAVXQXG%2BaqWwyQi=TM6P81A2tEG9KEA90jsZg@mail.gmail.com> In-Reply-To: <CANCZdfrW%2Ba=fX21dzuHEERwC38je7nkTiJ0nssZ75JYU-ni8VQ@mail.gmail.com> References: <201808082137.w78Lb2B5031967@repo.freebsd.org> <CAF6rxgm3x=fQB2OqrE=zoi89qGR0KTuST_AiEzf%2BaGtsGY_DyA@mail.gmail.com> <CACNAnaGjdBa5mmiiOe8O%2BomsBSA5YOCUnLDEL-jCcaSRQZKsTQ@mail.gmail.com> <CANCZdfrW%2Ba=fX21dzuHEERwC38je7nkTiJ0nssZ75JYU-ni8VQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 8, 2018 at 8:15 PM, Warner Losh <imp@bsdimp.com> wrote: > > > On Wed, Aug 8, 2018 at 7:01 PM, Kyle Evans <kevans@freebsd.org> wrote: >> >> On Wed, Aug 8, 2018 at 7:58 PM, Eitan Adler <lists@eitanadler.com> wrote: >> > On Wed, 8 Aug 2018 at 14:37, Kyle Evans <kevans@freebsd.org> wrote: >> >> +/* ARGSUSED */ >> > >> > We've been slowly delintifying system utilities. Why do we still keep >> > these comments? >> > >> >> This is consistent with the style of the file, so I didn't object. >> I'd rather do another pass later to de-lintify the whole thing rather >> than nitpick at this patch for some otherwise harmless and matching >> comments. =) > > > It appears to be from NetBSD upstream, so removing it would be pointless > churn that makes things harder to merge. > Poking at NetBSD now that I have time, it doesn't look like they actually have this feature. They have progress=<n> to output a dog every n blocks, but apparently not one that actually does a single-line summary every second like this and GNU dd (with the same status=progress flag).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaEufMXasfAVXQXG%2BaqWwyQi=TM6P81A2tEG9KEA90jsZg>