Date: Sun, 1 Jun 2008 05:30:12 GMT From: Matthew Luckie <mjl@luckie.org.nz> To: freebsd-bugs@FreeBSD.org Subject: Re: bin/123807: [patch] timed does not run on arm (incorrect getopt usage) Message-ID: <200806010530.m515UCjP089165@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR bin/123807; it has been noted by GNATS. From: Matthew Luckie <mjl@luckie.org.nz> To: Giorgos Keramidas <keramida@freebsd.org> Cc: bug-followup@freebsd.org Subject: Re: bin/123807: [patch] timed does not run on arm (incorrect getopt usage) Date: Sun, 01 Jun 2008 17:23:33 +1200 > The first hunk of the patch looks ok, but do we really need the second > one too? There are far too many places where an `int' return from > getopt() is compared with '?'-style characters in switch(), so if we > don't need it let's not add a cast. you're right, the cast is not required.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200806010530.m515UCjP089165>