Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 May 2003 13:08:46 -0700 (PDT)
From:      Julian Elischer <julian@elischer.org>
To:        Daniel Eischen <eischen@pcnet1.pcnet.com>
Cc:        David Xu <davidxu@freebsd.org>
Subject:   Re: kern_threads.c..  upcall question..
Message-ID:  <Pine.BSF.4.21.0305071307260.47162-100000@InterJet.elischer.org>
In-Reply-To: <Pine.GSO.4.10.10305060910120.11430-100000@pcnet1.pcnet.com>

index | next in thread | previous in thread | raw e-mail



On Tue, 6 May 2003, Daniel Eischen wrote:

> On Tue, 6 May 2003, Julian Elischer wrote:
> > 
> > On Tue, 6 May 2003, David Xu wrote:
> > 
> > > 
> > > > I think this could be optimised even more.
> > > > (why copy the FP regs if they are not valid) (etc).
> > > > but it is an improvement..
> > > > 
> > > 
> > > Why need we an intermediate mcontext_t, why not
> > > direct copy the context in trap frame to userland space?
> > > This should be fastest. :-)
> > 
> > this is what I was thinking..
> > get_mcontext_user(td, addr)
> > [...]
> 
> Don't break validation and setting of FP validity and type.
> get_mcontext() knows how to mark the validity of the FPU
> set and it's type (387 or SSE).  The UTS relies on this
> information.  Be very careful.

Can you test david's simple patch that just removes the copy-in?
We can wate til later to do the optimisations..

> 
> -- 
> Dan Eischen
> 
> 


help

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0305071307260.47162-100000>