Date: Sat, 10 Jun 2023 07:06:14 +0000 From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 271925] chflags(1) fails to remove uarch flag with hardlinked files (ZFS) Message-ID: <bug-271925-227-neE9jdRcZx@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-271925-227@https.bugs.freebsd.org/bugzilla/> References: <bug-271925-227@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D271925 Stefan E=C3=9Fer <se@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |se@FreeBSD.org --- Comment #1 from Stefan E=C3=9Fer <se@FreeBSD.org> --- Created attachment 242708 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D242708&action= =3Dedit Update stat info of file to be changed This seems to be caused by ZFS collecting multiple flag updates and by effectively mapping the setting of flags to toggling of flags. I'm not sure that I fully understand the complex mapping of attributes in sys/module/os/freebsd/zfs/zfs_vnops_os.c (line 4888ff), but I guess that the second call sees that the new attributes are identical to the (already alte= red) current attributes of the file and then marks it to not need a vnode update= on stable storage. Anyway, the attached simple patch fixes the issue on ZFS. I chose to update= the flags in place instead of in a separate stat structure. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-271925-227-neE9jdRcZx>