Date: Wed, 12 Sep 2018 17:53:44 +0000 From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 231151] ifconfig: unable to disable rxcsum, rxcsum6 and vlanhwcsum on em driver Message-ID: <bug-231151-7501-bB2zVgcK2W@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-231151-7501@https.bugs.freebsd.org/bugzilla/> References: <bug-231151-7501@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231151 --- Comment #8 from Stephen Hurd <shurd@FreeBSD.org> --- (In reply to Kaho Toshikazu from comment #7) > the variable setmask should be also masked by isc_capabilities, I think. Everything going into setmask should be masked by mask already... I've got that fixed in my patch now, will update right away. > No, it is not broken. I meant in the existing code, not in your patch. I'm trying to figure out why the old code was forcing only IFCAP_WOL_MCAST|IFCAP_WOL_MAGIC if any WoL flag (including IFCAL_WOL_UCAST) was set. If a driver requires something like this, and the isc_capabilities isn't enough to restrict it, there needs to be a flag, a callback, or at least an update to some manpages regarding it. It's almost certainly better to set the WoL capabilities as specified and have some not work then it is to not allow some to be specified at all or to change what set is enabled. > But the Wol feature doesn't have any effect until shutdown or suspend time, and set flags only and avoid re-initialization. Yeah, that part is good. We may actually want a larger set of things that don't reinit. > The vlan_hwcsum is simply forgot in the definition IFCAP_FLAGS. You also moved the if_vlancap(ifp) line to after the reinit. I'm trying to figure out if it should be set while the interface is stopped. It currently doesn't really make a difference as far as I can tell, but it may make sense to update while the interface is down, but then the context will be locked. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231151-7501-bB2zVgcK2W>