Date: Fri, 1 Aug 2003 14:44:54 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: Bruce Evans <bde@zeta.org.au>, Gordon Tetlow <gordon@FreeBSD.org> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/rescue/rescue Makefile Message-ID: <p052106afbb5062443cde@[128.113.24.47]> In-Reply-To: <20030802000356.P1436@gamplex.bde.org> References: <200308010904.h7194W4a061763@repoman.freebsd.org> <20030802000356.P1436@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At 12:11 AM +1000 8/2/03, Bruce Evans wrote:
>On Fri, 1 Aug 2003, Gordon Tetlow wrote:
>
>> gordon 2003/08/01 02:04:32 PDT
>>
>> FreeBSD src repository
>>
>> Modified files:
>> rescue/rescue Makefile
>> Log:
> > When using crunchgen, blow away MAKEFLAGS. This fixes
> > make -j <#> -P from passing the -P flag to crunchgen
> > which seems to confuse crunchgen horribly.
>
>Doesn't also prevent make -j <#> -P from passing the -j <#>
>flag and any other useful flags that may be in MAKEFLAGS?
Yes, but chances are that '-j' isn't going to make much of
a significant difference when crunchgen is building it's
makefiles. I'm not even sure that it is safe for '-j' (I
actually have no idea whether it is safe or not).
> > This is the preferable solution to modifing crunchgen to
>> unset the MAKEFLAGS environment variable.
>
>Certainly, since unsetting MAKEFLAGS very generally would be
>more likely to lose something important in it.
>
>Setting MAKEFLAGS to ${MAKEFLAGS:N-P} might be safe enough
>to do generally.
crunchgen also fails if you specify any debugging flags on
the original 'make' command, so the problem is much more
than just -P.
By making this change in the rescue Makefile, we'll quickly
sidestep a number of surprise headaches for someone trying
to do buildworlds. But at the same time, if someone really
wants crunchgen to run *it's* 'make' with some flags set,
they will have an easy way to do that. Also, this change
only effects building src/rescue, and not does not effect any
other users of crunchgen.
A better fix would be to make crunchgen a lot smarter about
the output (from make) that it is parsing, but that will also
take longer to write up. I do hope to look into that, but
probably not right away.
--
Garance Alistair Drosehn = gad@gilead.netel.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p052106afbb5062443cde>