Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 27 May 2026 15:30:08 +0000
From:      Christos Margiolis <christos@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 6f130b220d7c - main - sound: Remove dead EQ FEEDEQ_DISABLE code
Message-ID:  <6a170e00.27f29.454c1d56@gitrepo.freebsd.org>

index | next in thread | raw e-mail

The branch main has been updated by christos:

URL: https://cgit.FreeBSD.org/src/commit/?id=6f130b220d7ce64ce65f076a21edea034d14482b

commit 6f130b220d7ce64ce65f076a21edea034d14482b
Author:     Christos Margiolis <christos@FreeBSD.org>
AuthorDate: 2026-04-17 15:05:33 +0000
Commit:     Christos Margiolis <christos@FreeBSD.org>
CommitDate: 2026-05-27 15:27:11 +0000

    sound: Remove dead EQ FEEDEQ_DISABLE code
    
    If EQ is disabled, we never reach those code paths in the first place.
    
    Sponsored by:   The FreeBSD Foundation
    MFC after:      1 week
    Pull Request:   https://ron-dev.freebsd.org/FreeBSD/src/pulls/15
---
 sys/dev/sound/pcm/feeder_eq.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/sys/dev/sound/pcm/feeder_eq.c b/sys/dev/sound/pcm/feeder_eq.c
index 8f3acbf4e156..fe47a9d7e434 100644
--- a/sys/dev/sound/pcm/feeder_eq.c
+++ b/sys/dev/sound/pcm/feeder_eq.c
@@ -148,19 +148,6 @@ feed_eq_biquad(struct feed_eq_info *info, uint8_t *dst, uint32_t count,
 	pmul = feed_eq_preamp[info->preamp].mul;
 	pshift = feed_eq_preamp[info->preamp].shift;
 
-	if (info->state == FEEDEQ_DISABLE) {
-		j = count * info->channels;
-		dst += j * AFMT_BPS(fmt);
-		do {
-			dst -= AFMT_BPS(fmt);
-			v = pcm_sample_read(dst, fmt);
-			v = ((intpcm64_t)pmul * v) >> pshift;
-			pcm_sample_write(dst, v, fmt);
-		} while (--j != 0);
-
-		return;
-	}
-
 	treble = &(info->coeff[info->treble.gain].treble);
 	bass   = &(info->coeff[info->bass.gain].bass);
 
@@ -369,9 +356,6 @@ feed_eq_feed(struct pcm_feeder *f, struct pcm_channel *c, uint8_t *b,
 
 	info = f->data;
 
-	if (info->state == FEEDEQ_DISABLE)
-		return (FEEDER_FEED(f->source, c, b, count, source));
-
 	dst = b;
 	count = SND_FXROUND(count, info->align);
 


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?6a170e00.27f29.454c1d56>