Date: Sat, 14 Apr 2007 15:40:28 -0400 From: Kris Kennaway <kris@obsecurity.org> To: lesi@FreeBSD.org, x11@FreeBSD.org Subject: Upgrade script Message-ID: <20070414194028.GB2313@xor.obsecurity.org>
next in thread | raw e-mail | index | archive | help
--oLBj+sq0vYjzfsbl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline The script is basically OK, but it needs some more error checking: * It should bail if the backup tarball fails (e.g. disk full) * Before spamming /usr/local there needs to be a check that no files will be skipped (since you are using tar -k to avoid overwriting existing files). Probably something using find -type f -o -type l and then comm(1) would be appropriate; the user should be warned about these conflicts and either bail out until they resolve them, or just proceed and let them deal with them by hand from the backup tarball. * There is also the possibility for directories to change permissions/ownership when they are spammed by tar. This is probably not important though. Thanks, Kris --oLBj+sq0vYjzfsbl Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQFGIS4sWry0BWjoQKURAo9JAKDkSpsxu9xNaMlY9+3z9Am5rxg+OwCdHsmb 1fjjYxvRPEs0aw7VZ6YpJa0= =rMCt -----END PGP SIGNATURE----- --oLBj+sq0vYjzfsbl--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070414194028.GB2313>