Date: Fri, 24 Mar 2006 06:46:07 GMT From: Warner Losh <imp@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 93919 for review Message-ID: <200603240646.k2O6k72O058378@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=93919 Change 93919 by imp@imp_Speedy on 2006/03/24 06:45:21 report errors in some 'can't happen' cases to make sure that they are noticed. Affected files ... .. //depot/projects/arm/src/sys/arm/at91/at91.c#14 edit Differences ... ==== //depot/projects/arm/src/sys/arm/at91/at91.c#14 (text+ko) ==== @@ -201,11 +201,14 @@ struct at91_ivar *ivar; kid = device_add_child_ordered(dev, prio, name, unit); - if (kid == NULL) - return; + if (kid == NULL) { + printf("Can't add child %s%d ordered\n", name, unit); + return; + } ivar = malloc(sizeof(*ivar), M_DEVBUF, M_WAITOK | M_ZERO); if (ivar == NULL) { device_delete_child(dev, kid); + printf("Can't add alloc ivar\n"); return; } device_set_ivars(kid, ivar);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200603240646.k2O6k72O058378>