Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 16 Jan 2009 01:10:42 +0100
From:      Dimitry Andric <dimitry@andric.com>
To:        Marcel Moolenaar <xcllnt@mac.com>
Cc:        Randy Bush <randy@psg.com>, Luiz Otavio O Souza <lists.br@gmail.com>, George Neville-Neil <gnn@neville-neil.com>, Ben Kaduk <minimarmot@gmail.com>, current@freebsd.org
Subject:   Re: GEOM and moving to CURRENT from 7.1
Message-ID:  <496FD082.6030509@andric.com>
In-Reply-To: <DBB310AB-75BF-4BF7-AA35-63ADBD0B66B6@mac.com>
References:  <FC3D3CF7-091B-4ECF-BE38-6C7751C20994@neville-neil.com>	<alpine.BSF.2.00.0901112002080.3696@ibyngvyr.purzvxnyf.bet>	<496D0364.2060505@psg.com>	<47d0403c0901131335h46e7b151p3768de9a3e2c2027@mail.gmail.com>	<EC370904A7B74B93887C79E120CA2835@adnote989>	<085BEE07-BAE5-4A45-A14D-9587987FAA5C@mac.com>	<496F44FA.1070004@andric.com>	<48C1C477-B7BE-43B0-AC57-9DEB7BF9AA88@mac.com>	<496F7347.4060007@andric.com>	<A8E47805-888E-4282-8623-72A65B593D47@mac.com>	<496F8D8A.1060508@andric.com>	<BC6ACB2A-CBC5-428B-8749-999B48B2D1C8@mac.com>	<496F928F.6010807@andric.com> <DBB310AB-75BF-4BF7-AA35-63ADBD0B66B6@mac.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2009-01-15 20:55, Marcel Moolenaar wrote:
> Thanks *very* much for testing! It's important that we
> get the details right, so that we can consider adding
> code to help in the migration and fix whatever is broken.

In sysinstall, a standard installation writes the disks like so:

usr.sbin/sysinstall/install.c:  installStandard()
usr.sbin/sysinstall/install.c:  installCommit()
usr.sbin/sysinstall/install.c:  installInitial()
usr.sbin/sysinstall/label.c:    diskLabelCommit()
usr.sbin/sysinstall/disks.c:    diskPartitionWrite()
lib/libdisk/write_i386_disk.c:  Write_Disk()

It looks like Write_Disk() always writes a partition table:

int
Write_Disk(const struct disk *d1)
{
[...]
	struct dos_partition *dp,work[NDOSPART];

[...]
	for (c1 = d1->chunks->part; c1; c1 = c1->next) {
[... fills dp here ...]
	}

[...]
	memcpy(mbrblk + DOSPARTOFF, dp, sizeof *dp * NDOSPART);
	mbrblk[512-2] = 0x55;
	mbrblk[512-1] = 0xaa;
	write_block(fd, 0, mbrblk, d1->sector_size);
[...]



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?496FD082.6030509>