Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Apr 2018 11:08:10 -0500
From:      Kyle Evans <kevans@freebsd.org>
To:        "Rodney W. Grimes" <rgrimes@freebsd.org>
Cc:        Kyle Evans <kevans@freebsd.org>, src-committers <src-committers@freebsd.org>,  svn-src-all@freebsd.org, svn-src-stable@freebsd.org,  svn-src-stable-11@freebsd.org
Subject:   Re: svn commit: r331880 - stable/11/etc
Message-ID:  <CACNAnaGdOhBP3hjTJoRaQKgLUmzG-JRfXVYXdCBSQJScyMMS7Q@mail.gmail.com>
In-Reply-To: <201804021539.w32FdaID083096@pdx.rh.CN85.dnsmgr.net>
References:  <201804021528.w32FSmd7023856@repo.freebsd.org> <201804021539.w32FdaID083096@pdx.rh.CN85.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 2, 2018 at 10:39 AM, Rodney W. Grimes
<freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
>> Author: kevans
>> Date: Mon Apr  2 15:28:48 2018
>> New Revision: 331880
>> URL: https://svnweb.freebsd.org/changeset/base/331880
>>
>> Log:
>>   MFC r328331: Support configuring arbitrary limits(1) for any rc.conf daemon
>>
>>   Usage is ${name}_limits, and the argument is any flags accepted by
>>   limits(1), such as `-n 100' (e.g. only allow 100 open files).
>>
>> Modified:
>>   stable/11/etc/rc.subr
>> Directory Properties:
>>   stable/11/   (props changed)
>>
>> Modified: stable/11/etc/rc.subr
>> ==============================================================================
>> --- stable/11/etc/rc.subr     Mon Apr  2 15:07:41 2018        (r331879)
>> +++ stable/11/etc/rc.subr     Mon Apr  2 15:28:48 2018        (r331880)
>> @@ -773,6 +773,8 @@ check_startmsgs()
>>  #
>>  #    ${name}_login_class n   Login class to use, else "daemon".
>>  #
>> +#    ${name}_limits  n       limits(1) to apply to ${command}.
>> +#
>
> Caution, limits(1) is in /usr/bin, this code can fail if used before
> /usr is mounted.  (Ie, our rc.initdiskless) is probably broken by
> this change if a call is made to limits.
>

I believe this is a non-issue in this case-- this didn't add any
limits(1) invocations, it just allowed flags to be passed to the
limits(1) invocation that was already being made.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGdOhBP3hjTJoRaQKgLUmzG-JRfXVYXdCBSQJScyMMS7Q>