Date: Tue, 14 Nov 1995 18:22:25 +1100 From: Bruce Evans <bde@zeta.org.au> To: bde@freefall.freebsd.org, davidg@Root.COM Cc: CVS-commiters@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/nfs nfs_syscalls.c Message-ID: <199511140722.SAA00861@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>>bde 95/11/13 21:16:38
>>
>> Modified: sys/nfs nfs_syscalls.c
>> Log:
>> Included <sys/sysproto.h> to get central declarations for syscall args
>> structs and prototypes for syscalls.
>>
>> Ifdefed duplicated decentralized declarations of args structs. It's
>> convenient to have this visible but they are hard to maintain. Some
>> are already different from the central declarations. 4.4lite2 puts
>> them in comments in the function headers but I wanted to avoid the
>> large changes for that.
> Now that the definitions are in sysproto.h, I'd like to see them removed
>from the .c files.
I'm not sure if they should be removed as far as that. Do you think we
should remove the pseudo-declarations from all vnode op functions too?
Such declarations are useful iff they are correct. For examples of
possibly harmful incorrect ones, see almost any readdir():
ext2fs_readdir(): eofflag and cookies are missing
eofflag and cookies aren't referenced so nfs can't work
ufs_readdir(): eofflag is missing but is referenced (nfs works :-)
msdosfs_readdir(): members are out of order
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199511140722.SAA00861>