Date: Wed, 28 Mar 2007 15:00:41 +0200 From: Andre Oppermann <andre@freebsd.org> To: Andrey Chernov <ache@freebsd.org>, Andre Oppermann <andre@freebsd.org>, Garrett Cooper <youshi10@u.washington.edu>, freebsd-current@freebsd.org Subject: Re: Latest -current complete lockup (tcp changes?) Message-ID: <460A66F9.7000005@freebsd.org> In-Reply-To: <20070328085104.GA20674@nagual.pp.ru> References: <200703251620.20879.nb_root@videotron.ca> <20070325202749.GA1503@kobe.laptop> <460705AE.5040107@freebsd.org> <20070327045252.GA3256@nagual.pp.ru> <46099675.3040609@u.washington.edu> <20070327052810.GA772@nagual.pp.ru> <20070327054501.GA1026@nagual.pp.ru> <46090BA6.5060206@freebsd.org> <20070328074611.GA19740@nagual.pp.ru> <460A2B97.9040404@freebsd.org> <20070328085104.GA20674@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
Andrey Chernov wrote: > On Wed, Mar 28, 2007 at 10:47:19AM +0200, Andre Oppermann wrote: >> Andrey Chernov wrote: >>> On Tue, Mar 27, 2007 at 02:18:46PM +0200, Andre Oppermann wrote: >>> >>>> Could you revert sys/netinet/tcp_input.c back to rev. 1.327 while leaving >>>> all others at HEAD and look if the bug can be reproduced? >>> >>> Yes! Reverting to 1.327 really helps, lockup is gone! Thanx! >> You tried with a fully updated system before the backout as well? >> There was a time window where TCP was indeed broken. It panic'ed >> though. > > Yes. My case is not related to SACK options KASSERT - my kernel even not > go so far to get that panic and I get lockup even when disable SACK by > sysctl. The problem is fixed in rev. 1.330 of tcp_input.c. Thanks to Robert for finding the bug. It was a INP_INFO_LOCK leak in the blackhole case that I missed during the tcp_input() split. There was a slight change in semantics. Sorry for the trouble. -- Andre
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?460A66F9.7000005>