Date: Sun, 30 Oct 2016 15:05:49 -0700 From: John Baldwin <jhb@freebsd.org> To: Li-Wen Hsu <lwhsu@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308107 - in head/sys/modules/bhnd: . bcma bcma_bhndb bhndb bhndb_pci cores/bhnd_pci cores/bhnd_pci_hostb cores/bhnd_pcib siba siba_bhndb Message-ID: <4862480.RxOcpDe54A@ralph.baldwin.cx> In-Reply-To: <201610301556.u9UFuhAi009407@repo.freebsd.org> References: <201610301556.u9UFuhAi009407@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sunday, October 30, 2016 03:56:43 PM Li-Wen Hsu wrote: > Author: lwhsu (ports committer) > Date: Sun Oct 30 15:56:42 2016 > New Revision: 308107 > URL: https://svnweb.freebsd.org/changeset/base/308107 > > Log: > - Fix `make` in sys/modules/bhnd > > Approved by: landonf > Differential Revision: https://reviews.freebsd.org/D7774 This is wrong. bhnd_debug.h should not have '#include opt_global.h'. It is included implicitly during kernel builds via '-include' in CFLAGS. It is always incorrect to include it explicitly in source. This should be reverted and bhnd_debug.h should be fixed instead. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4862480.RxOcpDe54A>