Date: Sun, 26 Jul 2009 22:23:54 GMT From: Sylvestre Gallon <syl@FreeBSD.org> To: Perforce Change Reviews <perforce@FreeBSD.org> Subject: PERFORCE change 166601 for review Message-ID: <200907262223.n6QMNs1A062518@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=166601 Change 166601 by syl@syl_twoflowers on 2009/07/26 22:22:59 - add generic symbols Affected files ... .. //depot/projects/soc2009/syl_usb/hps_report/GenericCode.tex#2 edit Differences ... ==== //depot/projects/soc2009/syl_usb/hps_report/GenericCode.tex#2 (text+ko) ==== @@ -51,13 +51,47 @@ - xxxdci\_init - xxxdci\_uninit + + - xxxdci\_device\_done + - xxxdci\_start\_standard\_chain + Concerning clock\_on, clock\_off, pull\_up, pull\_down, wakeup\_peer can be a little bit factorised. A big part of this function do not move we can create a generic function called directly after or before Hardware changes. Perhaps there is also something that could be factorised in xxxdci\_uninit if there are not other possible access that interrupt disabling in it. + There are pehaps something to do with xxxdci\_device\_done and xxxdci\_start\_standard\_chain + beacuse the only hardware code present int this function just enable Endpoint interrupt. + \section{Hardware Independant Code} + - xxxdci\_ep\_init + + - xxxdci\_xfer\_setup + + - xxxdci\_roothub\_exec + + - All the HUB descriptor code + + - xxxdci\_device\_XXX\_methods + + - xxxdci\_standard\_done + + - xxxdci\_standard\_done\_sub + + - xxxdci\_root\_intr + + - xxxdci\_timeout + + - xxxdci\_setup\_standard\_chain + - xxxdci\_setup\_standard\_chain\_sub + + - xxxdci\_vbus\_interrupt + + - xxxdci\_interrupt\_poll + + - xxxdci\_xfer\_do\_fifo +
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200907262223.n6QMNs1A062518>