Date: Tue, 26 Jul 2016 18:27:07 +0200 From: Ed Schouten <ed@nuxi.nl> To: Ed Maste <emaste@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r303338 - head/sys/dev/vt Message-ID: <CABh_MKm9eQc5fdPxDu2i_F7BUa4sasB_iy3w67_q9g__OThUoQ@mail.gmail.com> In-Reply-To: <201607261534.u6QFYQ9L017045@repo.freebsd.org> References: <201607261534.u6QFYQ9L017045@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Ed,
2016-07-26 17:34 GMT+02:00 Ed Maste <emaste@freebsd.org>:
> if (vw == vd->vd_curwindow) {
> + mtx_lock(&Giant);
> kbd = kbd_get_keyboard(vd->vd_keyboard);
> if (kbd != NULL)
> vt_save_kbd_state(vw, kbd);
> + mtx_unlock(&Giant);
> }
Would it make sense to put an mtx_assert(&Giant, MA_OWNED) in
kbd_get_keyboard()?
--
Ed Schouten <ed@nuxi.nl>
Nuxi, 's-Hertogenbosch, the Netherlands
KvK-nr.: 62051717
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABh_MKm9eQc5fdPxDu2i_F7BUa4sasB_iy3w67_q9g__OThUoQ>